[ 
https://issues.apache.org/jira/browse/LUCENE-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602775#comment-13602775
 ] 

Adrien Grand commented on LUCENE-4830:
--------------------------------------

bq. I think that we should make the DocMap impl final? Maybe it will encourage 
JIT ...

Looks like it doesn't help much? 
http://stackoverflow.com/questions/8354412/do-java-finals-help-the-compiler-create-more-efficient-bytecode
                
> Sorter API: use an abstract doc map instead of an array
> -------------------------------------------------------
>
>                 Key: LUCENE-4830
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4830
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Trivial
>             Fix For: 4.3
>
>         Attachments: LUCENE-4830.patch
>
>
> The sorter API uses arrays to store the old->new and new->old doc IDs 
> mappings. It should rather be an abstract class given that in some cases an 
> array is not required at all (reverse mapping for example).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to