[ 
https://issues.apache.org/jira/browse/LUCENE-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603427#comment-13603427
 ] 

Robert Muir commented on LUCENE-4752:
-------------------------------------

I disagree... and I guess I'm willing to go to bat for this.

There is real cost in exposing stuff like this. I'm already frustrated about 
the amount of stuff around this area that is 'public' solely due to packaging 
(e.g. the .codecs package and the .index package both need it).

Finally, if we have code in lucene itself that relies upon the inner details 
because it e.g. subclasses segmentmerger, this makes it harder to refactor core 
lucene and evolve it in the future because we have modules doing sorting or 
shuffling or god knows what that rely upon its api. in such a case where i want 
to refactor SM, i could just eradicate those modules and nobody would complain, 
right?

I don't think we should do it.

                
> Merge segments to sort them
> ---------------------------
>
>                 Key: LUCENE-4752
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4752
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: core/index
>            Reporter: David Smiley
>            Assignee: Adrien Grand
>         Attachments: LUCENE-4752.patch
>
>
> It would be awesome if Lucene could write the documents out in a segment 
> based on a configurable order.  This of course applies to merging segments 
> to. The benefit is increased locality on disk of documents that are likely to 
> be accessed together.  This often applies to documents near each other in 
> time, but also spatially.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to