[ 
https://issues.apache.org/jira/browse/SOLR-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603762#comment-13603762
 ] 

Shawn Heisey commented on SOLR-4586:
------------------------------------

bq. I'd have to dig to be sure. I also thought I remember shawn saying in irc 
that he confirmed that no code was reading this setting in solr anymore.

I was wrong about the value not actually being used anywhere.  I think that can 
be attributed to not grokking Lucene internals and having only a short history 
with Java.  I have since located the following bit of code that is removed from 
SolrCore.java by my patch.  At the time it didn't look like anything important.

{code}
BooleanQuery.setMaxClauseCount(boolean_query_max_clause_count);
{code}

                
> Remove maxBooleanClauses from Solr
> ----------------------------------
>
>                 Key: SOLR-4586
>                 URL: https://issues.apache.org/jira/browse/SOLR-4586
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.2
>            Reporter: Shawn Heisey
>         Attachments: SOLR-4586.patch
>
>
> In the #solr IRC channel, I mentioned the maxBooleanClauses limitation to 
> someone asking a question about queries.  Mark Miller told me that 
> maxBooleanClauses no longer applies, that the limitation was removed from 
> Lucene sometime in the 3.x series.  The config still shows up in the example 
> even in the just-released 4.2.
> Checking through the source code, I found that the config option is parsed 
> and the value stored in objects, but does not actually seem to be used by 
> anything.  I removed every trace of it that I could find, and all tests still 
> pass.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to