[
https://issues.apache.org/jira/browse/SOLR-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603823#comment-13603823
]
Jack Krupansky edited comment on SOLR-4586 at 3/15/13 8:59 PM:
---------------------------------------------------------------
Several years ago when I looked at this, there was only a check in BooleanQuery
to see if the limit was exceeded, but otherwise Lucene was in no way dependent
on the value of that limit.
So, I recommend removing support for the limit from Lucene as well.
Actually, I would recommend deprecating the maxBooleanClauses feature of both
Lucene and Solr in 4.3, and removing the feature from trunk, 5.0.
As a backup plan, if the Lucene guys don't want to remove the limit, Solr
should simply set the limit to Integer.MAX_VALUE, but otherwise remove all
references to the "feature" in Solr itself.
was (Author: jkrupan):
Several years ago when I looked at this, there was only a check in
BooleanQuery to see if the limit was exceeded, but otherwise Lucene was in no
way dependent on the value of that limit.
So, I recommend removing support for the limit from Lucene as well.
Actually, I would recommend deprecating the maxBooleanClauses feature of both
Lucene and Solr in 4.3, and removing the feature from trunk, 5.0.
> Remove maxBooleanClauses from Solr
> ----------------------------------
>
> Key: SOLR-4586
> URL: https://issues.apache.org/jira/browse/SOLR-4586
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.2
> Environment: 4.3-SNAPSHOT 1456767M - ncindex - 2013-03-15 13:11:50
> Reporter: Shawn Heisey
> Attachments: SOLR-4586.patch
>
>
> In the #solr IRC channel, I mentioned the maxBooleanClauses limitation to
> someone asking a question about queries. Mark Miller told me that
> maxBooleanClauses no longer applies, that the limitation was removed from
> Lucene sometime in the 3.x series. The config still shows up in the example
> even in the just-released 4.2.
> Checking through the source code, I found that the config option is parsed
> and the value stored in objects, but does not actually seem to be used by
> anything. I removed every trace of it that I could find, and all tests still
> pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
