[ 
https://issues.apache.org/jira/browse/LUCENE-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-4838:
-------------------------------

    Attachment: LUCENE-4838.patch

Renamed to find and replaced all mentions of 'ord' and 'ordinal' by 'id' and 
'bytesID' (depending on context).

Simon, I couldn't use find() in add() because the lookup code modifies the 
hashcode given to the method, which is later used to add the new entry. So 
find() needs to return two values (the id and modified hashcode), which 
unfortunately we can't do. Anyway, this is not such a long code.

I think it's ready.
                
> Add getOrd to BytesRefHash
> --------------------------
>
>                 Key: LUCENE-4838
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4838
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: core/other
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-4838.patch, LUCENE-4838.patch
>
>
> There is no API today to query BytesRefHash for the existence of a certain 
> BytesRef. Rather, you should use .add(), which looks up the given bytes, and 
> hashes them if they are not found, or returns their ord if they are found.
> I would like to add a simple getOrd API which will return the ord of a given 
> BytesRef, or -1 if not found. I would like to use that API in the facet 
> module, and I need to be able to query the hash without necessarily adding 
> elements to it.
> I have a simple patch, will post shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to