ludovic Boutros created SOLR-4608:
-------------------------------------

             Summary: Update Log replay should use the default processor chain
                 Key: SOLR-4608
                 URL: https://issues.apache.org/jira/browse/SOLR-4608
             Project: Solr
          Issue Type: Bug
          Components: SolrCloud
    Affects Versions: 4.2, 4.1
            Reporter: ludovic Boutros


If a processor chain is used with custom processors, 
they are not used in case of node failure during log replay.

Here is the code:

{code:title=UpdateLog.java|borderStyle=solid}
    public void doReplay(TransactionLog translog) {
      try {
        loglog.warn("Starting log replay " + translog + " active="+activeLog + 
" starting pos=" + recoveryInfo.positionOfStart);

        tlogReader = translog.getReader(recoveryInfo.positionOfStart);

        // NOTE: we don't currently handle a core reload during recovery.  This 
would cause the core
        // to change underneath us.

        // TODO: use the standard request factory?  We won't get any custom 
configuration instantiating this way.
        RunUpdateProcessorFactory runFac = new RunUpdateProcessorFactory();
        DistributedUpdateProcessorFactory magicFac = new 
DistributedUpdateProcessorFactory();
        runFac.init(new NamedList());
        magicFac.init(new NamedList());

        UpdateRequestProcessor proc = magicFac.getInstance(req, rsp, 
runFac.getInstance(req, rsp, null));
{code} 

I think this is a big issue, because a lot of people will discover it when a 
node will crash in the best case... and I think it's too late.

It means to me that processor chains are not usable with Solr Cloud currently.
 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to