[
https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608790#comment-13608790
]
Uwe Schindler commented on LUCENE-4848:
---------------------------------------
bq. There's a hook in the close() method of FSIndexOutput that calls
parent.onIndexOutputClosed(this). onIndexOutputClosed only accepts a
FSIndexOutput, not a BufferedIndexOutput.
This is not optimal, I would like to change this. I have no idea for which
reason this was added. FSDirectory should only expect a IndexOutput subclass
and not add magic here. We can fix this in the future, but thats also a
separate issue. So I would like to keep FSIndexOutput unchanged. I think the
callback with onIndexOutputClosed is also for testing purposes, I will review
the backgrounds.
I would like to commt the latest patch I upped and then upload a new patch with
your AsyncFS (again, only the IndexInput part) to the new issue.
> Fix Directory implementations to use NIO2 APIs
> ----------------------------------------------
>
> Key: LUCENE-4848
> URL: https://issues.apache.org/jira/browse/LUCENE-4848
> Project: Lucene - Core
> Issue Type: Task
> Affects Versions: 5.0
> Reporter: Michael Poindexter
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 5.0
>
> Attachments: jdk7directory.zip, LUCENE-4848-MMapDirectory.patch,
> LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch,
> LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch, LUCENE-4848.patch.txt
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on
> JDK7). These may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5
> for more details about this code and the advantages it provides.
> The code is attached as a zip to this issue. I'll be happy to make any
> changes requested. I've included some minimal smoke tests, but any help in
> how to use the normal Lucene tests to perform more thorough testing would be
> appreciated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
