[
https://issues.apache.org/jira/browse/SOLR-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609432#comment-13609432
]
James Dyer commented on SOLR-4361:
----------------------------------
Chris,
Do you have a real-world problem that is still broken, or is this just a
problem with modifying TestURLDataSource? This issue is tested in
TestVariableResolverEndToEnd. The solrconfig.xml file contains a default
parameter "dots.in.hsqldb.driver" with the driver name. The test subsequently
references <dataSource ...
driver="${dataimporter.request.dots.in.hsqldb.driver}" ... />. Prior to fixing
VariableResolver, this test would fail because the driver name would not
resolve. With this fix, the test passes.
The difference is that the "dataimporter.request" namespaces are (in reality)
added by DocBuilder#getVariableResolver by creating a map for the
"dataimporter" namespace and then a child map for the "request" namespace.
With the fix here, VariableResolver is still requiring each node in the
Variable tree to be added individually, rather than taking the shortcut you
used in your modified version of TestURLDataSource. However, it is more
forgiving with variable names containing dots: if it cannot walk the tree to
find the rightmost name, then it goes as far as it can and then assumes the
rest is a name with embedded dots in it.
> DIH request parameters with dots throws UnsupportedOperationException
> ---------------------------------------------------------------------
>
> Key: SOLR-4361
> URL: https://issues.apache.org/jira/browse/SOLR-4361
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.1
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Minor
> Fix For: 4.3, 5.0, 4.2.1
>
> Attachments: SOLR-4361.patch
>
>
> If the user puts placeholders for request parameters and these contain dots,
> DIH fails. Current workaround is to either use no dots or use the 4.0 DIH
> jar.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
