[ 
https://issues.apache.org/jira/browse/SOLR-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610548#comment-13610548
 ] 

Commit Tag Bot commented on SOLR-4051:
--------------------------------------

[branch_4x commit] James Dyer
http://svn.apache.org/viewvc?view=revision&revision=1408884

SOLR-4051: fix typo

                
> DIH Delta updates do not work for all locales
> ---------------------------------------------
>
>                 Key: SOLR-4051
>                 URL: https://issues.apache.org/jira/browse/SOLR-4051
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 4.0
>            Reporter: James Dyer
>            Assignee: James Dyer
>            Priority: Minor
>         Attachments: SOLR-4051.patch, SOLR-4051.patch
>
>
> DIH Writes the last modified date to a Properties file using the default 
> locale.  This gets sent in plaintext to the database at the next delta 
> update.  DIH does not use prepared statements but just puts the date in an 
> SQL Statement in yyyy-mm-dd hh:mm:ss format.  It would probably be best to 
> always format this date in JDBC escape syntax 
> (http://docs.oracle.com/javase/1.4.2/docs/guide/jdbc/getstart/statement.html#999472)
>  and java.sql.Timestamp#toString().  To do this, we'd need to parse the 
> user's query and remove the single quotes likely there (and now the quotes 
> would be optional and undesired).  
> It might just be simpler to change the SimpleDateFormat to use the root 
> locale as this appears to be the original intent here anyhow.  Affected 
> locales include ja_JP_JP , hi_IN , th_TH

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to