[
https://issues.apache.org/jira/browse/LUCENE-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610696#comment-13610696
]
Commit Tag Bot commented on LUCENE-4469:
----------------------------------------
[branch_4x commit] Robert Muir
http://svn.apache.org/viewvc?view=revision&revision=1396162
LUCENE-4469: fix these tests to actually fail if checkindex fails
> many Test2B* tests appear to be useless
> ---------------------------------------
>
> Key: LUCENE-4469
> URL: https://issues.apache.org/jira/browse/LUCENE-4469
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 4.1, 5.0
>
>
> for some reason (I guess debugging) these explicitly disable checkindex on
> MDW and call checkindex themselves.
> but they dont check its return value!
> So these tests could currently all be failing and we wouldnt know (since If i
> remember right, checkindex catches throwable and records it inside its status)
> These tests should be changed to just let MDW run the checkindex, or use
> _TestUtil.checkIndex.
> We should also search the codebase for any other tests doing this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
