[
https://issues.apache.org/jira/browse/LUCENE-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610823#comment-13610823
]
Commit Tag Bot commented on LUCENE-4380:
----------------------------------------
[branch_4x commit] Robert Muir
http://svn.apache.org/viewvc?view=revision&revision=1386616
LUCENE-4380: fix simplefs/niofs hierarchy
> fix simplefs/niofshierarchy
> ---------------------------
>
> Key: LUCENE-4380
> URL: https://issues.apache.org/jira/browse/LUCENE-4380
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4380.patch, LUCENE-4380.patch
>
>
> spinoff from LUCENE-4371:
> Currently NIOFSDirectory.NIOFSIndexInput extends
> SimpleFSDirectory.SimpleFSIndexInput, but this isn't an is-a relationship at
> all.
> Additionally SimpleFSDirectory has a funky Descriptor class that extends
> RandomAccessFile that is useless:
> {noformat}
> /**
> * Extension of RandomAccessFile that tracks if the file is
> * open.
> */
> ...
> // remember if the file is open, so that we don't try to close it
> // more than once
> {noformat}
> RandomAccessFile is closeable, this is not necessary and I don't think we
> should be subclassing it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
