[ 
https://issues.apache.org/jira/browse/SOLR-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611660#comment-13611660
 ] 

Andrzej Bialecki  commented on SOLR-4619:
-----------------------------------------

David, thanks for explaining - I see your point, and I like it too.

bq. It needs to examine the field value: if it's "Field" then it gets added 
right to the document.

Even if we push this functionality to an UpdateRequestProcessor it still needs 
to know when (not) to convert the input String to a Field. Do you have some 
thoughts about this?

In UpdateRequestProcessor we deal with SolrInputDocument-s in the context of 
available schema and solrconfig - so there are a few options how to determine 
the need for conversion.

# It could be based on the document itself (tricky, in the light of multiple 
serialization formats).
# OR, we could extend SolrInputField (and the document serializations) to 
support additional per-field flags to indicate this, but that would complicate 
matters even more.
# OR, if this decision is going to be based on schema we would have to extend 
schema to pass additional flags to mark fields as preanalyzed - also tricky.
# And finally, we could put the list of fields to always convert in the init 
args of this UpdateRequestProcessor in solrconfig ... but that's a bit ugly, 
mixing schema and solrconfig.
                
> Improve PreAnalyzedField query analysis
> ---------------------------------------
>
>                 Key: SOLR-4619
>                 URL: https://issues.apache.org/jira/browse/SOLR-4619
>             Project: Solr
>          Issue Type: Bug
>          Components: Schema and Analysis
>    Affects Versions: 4.0, 4.1, 4.2, 5.0, 4.2.1
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>             Fix For: 5.0
>
>         Attachments: SOLR-4619.patch
>
>
> PreAnalyzed field extends plain FieldType and mistakenly uses the 
> DefaultAnalyzer as query analyzer, and doesn't allow for customization via 
> <analyzer> schema elements.
> Instead it should extend TextField and support all query analysis supported 
> by that type.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to