[ 
https://issues.apache.org/jira/browse/LUCENE-4863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611702#comment-13611702
 ] 

Robert Muir commented on LUCENE-4863:
-------------------------------------

A few nits:
* This converts to UTF-8, but stores in a BYTE4 automaton. Is there a reason 
for BYTE4
* javadoc typeo "Adds an input string and it's stemmer overwrite output to this 
builder."
* should the ignoreCase be a property of the map itself rather than a separate 
param? synoymfilter has this same problem. If you didnt previously add to the 
map properly (e.g. lowercase) then this parameter won't work. 

                
> Use FST to hold term in StemmerOverrideFilter
> ---------------------------------------------
>
>                 Key: LUCENE-4863
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4863
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.2
>            Reporter: Simon Willnauer
>             Fix For: 5.0, 4.3
>
>         Attachments: LUCENE-4863.patch, LUCENE-4863.patch
>
>
> follow-up from LUCENE-4857

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to