[ 
https://issues.apache.org/jira/browse/LUCENE-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611829#comment-13611829
 ] 

Adrien Grand commented on LUCENE-4874:
--------------------------------------

This makes sense. I found another bug in SortingAtomicReader which doesn't 
override getCoreCacheKey, this could lead to very bad things if an atomic 
reader and its sorted view were both used with the same FieldCache instance.

I've started looking at methods that override default impls and would like to 
have your opinion on some of them:
 - shouldn't IndexReader.hasDeletions return numDeletedDocs() > 0 by default 
instead of being abstract?
 - isn't the default impl of TermsEnum.termState dangerous? Shouldn't it throw 
an UnsupportedOperationException or being abstract instead?
                
> Remove FilterTerms.intersect
> ----------------------------
>
>                 Key: LUCENE-4874
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4874
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Priority: Minor
>
> Terms.intersect is an optional method. The fact that it is overridden in 
> FilterTerms forces any non-trivial class that extends FilterTerms to override 
> intersect in order this method to have a correct behavior. If FilterTerms did 
> not override this method and used the default impl, we would not have this 
> problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to