[ 
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrien Grand updated LUCENE-4876:
---------------------------------

    Attachment: LUCENE-4876.patch

Patch:

 * MergeScheduler implements Cloneable

 * IndexDeletionPolicy is now an abstract class (so that it can provide a 
default clone impl) and implements Cloneable

 * InfoStream implements Cloneable (there is no need for this today but I 
assumed that some people might be interested to display line numbers or other 
things that would require adding a state to the InfoStream, I've no strong 
feeling about it and can remove it if you think it shouldn't implement 
Cloneable)

 * MergeSchedulers and IndexDeletionPolicies have been fixed so that clones 
don't share state with the instance they've been cloned from

 * IndexWriterConfig clones mergeScheduler and delPolicy (in addition to 
mergePolicy, flushPolicy and indexerThreadPool which were already cloned)

 * Most of the patch changes are due to the fact that many tests assumed that 
the IndexDeletionPolicy instance passed to IndexWriterConfig was the same one 
as the one used by IndexWriter (which is not true now since IndexWriter clones 
the provided config in its constructor and we now clone del policies in 
IndexWriterConfig.clone).
                
> IndexWriterConfig.clone should clone the MergeScheduler
> -------------------------------------------------------
>
>                 Key: LUCENE-4876
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4876
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>             Fix For: 4.3
>
>         Attachments: LUCENE-4876.patch
>
>
> ConcurrentMergeScheduler has a List<MergeThread> member to track the running 
> merging threads, so IndexWriterConfig.clone should clone the merge scheduler 
> so that both IndexWriterConfig instances are independant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to