[
https://issues.apache.org/jira/browse/LUCENE-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615811#comment-13615811
]
Michael McCandless commented on LUCENE-4876:
--------------------------------------------
+1, looks great!
IndexDeletionPolicy changed from an interface to abstract class ... I think
this is fine (even though it's not marked @lucene.experimental): it's obviously
very expert. Just make sure to advertise this break in the back compat break
CHANGES section.
Does PersistentSnapshotDeletionPolicy need clone() too? Hmm that doesn't seem
straightforward ... (can't clone the open IndexWriter). Maybe just add to its
javadocs that you should never try to share one instance of it across writers?
> IndexWriterConfig.clone should clone the MergeScheduler
> -------------------------------------------------------
>
> Key: LUCENE-4876
> URL: https://issues.apache.org/jira/browse/LUCENE-4876
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Fix For: 4.3
>
> Attachments: LUCENE-4876.patch
>
>
> ConcurrentMergeScheduler has a List<MergeThread> member to track the running
> merging threads, so IndexWriterConfig.clone should clone the merge scheduler
> so that both IndexWriterConfig instances are independant.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
