[ 
https://issues.apache.org/jira/browse/SOLR-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Dyer updated SOLR-3758:
-----------------------------

    Attachment: SOLR-3758.patch

Here's a patch that changes SpellCheckComponent#modifyRequest to do its work 
when the request purpose is ShardRequest.PURPOSE_GET_TOP_GROUPS rather than 
ShardRequest.PURPOSE_GET_TOP_IDS when grouping is enabled.  On grouped 
requests, intra-shard requests with ShardRequest.PURPOSE_GET_TOP_IDS are only 
sent to shards that contain Top Groups, so SpellCheckComponent wouldn't have 
the opportunity to find all of its suggestions in a grouped scenario. 

There is also a change to DistributedSpellCheckComponentTest to randomly enable 
grouping for each test scenario.  However, we still get failures related to the 
"correctlySpelled" flag and with the use of "alternativeTermCount".  So we 
still need to investigate why distributed vs non-dist return different results 
in these cases.

This patch I think is complete enough for evaluation purposes.
                
> DirectSolrSpellChecker doesn't work when using group.
> -----------------------------------------------------
>
>                 Key: SOLR-3758
>                 URL: https://issues.apache.org/jira/browse/SOLR-3758
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud, spellchecker
>    Affects Versions: 4.0-BETA
>         Environment: Linux Debian 6 / SolrCloud with 2 shards and 2 replicas.
>            Reporter: Christian Johnsson
>              Labels: DirectSolrSpellChecker, bug, spellchecker, suggestions
>         Attachments: SOLR-3758.patch
>
>
> It seems like spellchecker using solr.DirectSolrSpellChecker doesn't work 
> when grouping results.
> /select?q=mispeled
> Gives me correct spellingsuggestions
> but..
> /select?q=mispeled&group=true&group.main=true&group.field=title
> don't give any suggestions.
> It worked in 3.5 with indexbased spellchecker.
> It seems like if i mispell something that returns 0 results i dont get any 
> suggestions. If i misspell something that genereate a result i get 
> suggestions on it.
> It should come up with proper suggestions even if there are no results to be 
> displayed (But there is things that should be suggested).
> Long story short. Same functionality as in 3.5 :-)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to