[ 
https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616427#comment-13616427
 ] 

Mark Miller commented on SOLR-4196:
-----------------------------------

what im talking about is this:

{code}
  // We are shutting down. We don't want to risk deadlock, so do this 
manipulation the expensive way. Note, I've
  // already deadlocked with closing/opening cores while keeping locks here....
  protected void clearMaps(ConfigSolr cfg) {
{code}

And then below it clears cores and transient cores (both vars shared across 
threads) without a lock. This is the type of thing that will need to be fixed 
if we are to get rid of those fails in the stress test is my guess.
                
> Untangle XML-specific nature of Config and Container classes
> ------------------------------------------------------------
>
>                 Key: SOLR-4196
>                 URL: https://issues.apache.org/jira/browse/SOLR-4196
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 4.3, 5.0
>
>         Attachments: SOLR-4196.patch, SOLR-4196.patch, SOLR-4196.patch, 
> SOLR-4196.patch, SOLR-4196.patch, SOLR-4196.patch, SOLR-4196.patch, 
> SOLR-4196.patch, SOLR-4196.patch, SOLR-4196.patch, SOLR-4196.patch, 
> SOLR-4196.patch, SOLR-4196.patch, SOLR-4196.patch, StressTest.zip, 
> StressTest.zip, StressTest.zip, StressTest.zip
>
>
> sub-task for SOLR-4083. If we're going to try to obsolete solr.xml, we need 
> to pull all of the specific XML processing out of Config and Container. 
> Currently, we refer to xpaths all over the place. This JIRA is about 
> providing a thunking layer to isolate the XML-esque nature of solr.xml and 
> allow a simple properties file to be used instead which will lead, 
> eventually, to solr.xml going away.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to