[
https://issues.apache.org/jira/browse/SOLR-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617342#comment-13617342
]
David Smiley commented on SOLR-4648:
------------------------------------
Great start Andrzej!
Reviewing the patch...
I think PreAnalyzedUpdateProcessorFactory should extend [~janhoy]'s
FieldMutatingUpdateProcessorFactory, which will shorten some of your code and
give it more flexibility on how fields are matched.
In PreAnalyzedField line 112:
{code}
LOG.warn("Error parsing pre-analyzed field '" + field.getName() + "': " +
e.toString());
{code}
Shouldn't you pass 'e' as the last arg to warn()?
It would be interesting to test this against the example Solr schema with
pre-analyzing every field to see if it works, comparing the index output using
the SimpleTextCodec. I strongly suspect it won't, since there is more to the
state of a Field than it's tokenStream and stored value -- which seem to be the
only thing the code in this patch accounts for. For example its 'type' (Lucene
FieldType).
In summary, great start!
> Create a PreAnalyzedUpdateProcessor
> -----------------------------------
>
> Key: SOLR-4648
> URL: https://issues.apache.org/jira/browse/SOLR-4648
> Project: Solr
> Issue Type: Bug
> Components: update
> Affects Versions: 4.3, 5.0
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Fix For: 4.3, 5.0
>
> Attachments: SOLR-4648.patch, SOLR-4648.patch
>
>
> Spin-off from the discussion in SOLR-4619.
> Instead of using a PreAnalyzedField type we can use an UpdateRequestProcessor
> that converts any input field values to StorableField-s, using the
> PreAnalyzedParser-s, and then directly passes StorableField-s to
> DocumentBuilder for indexing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
