[ 
https://issues.apache.org/jira/browse/LUCENE-4893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618147#comment-13618147
 ] 

crocket edited comment on LUCENE-4893 at 3/30/13 8:27 PM:
----------------------------------------------------------

I assumed FacetsCollector.getFacetResults was a simple getter method, so I 
didn't optimize my code to call it once.

After discovering LUCENE-4893, I modified my code to call it once.

It may be a good idea to throw an exception or return an empty list if one 
calls it again.
There will be only so many lucene beginners with no knowledge of its side 
effects.
                
      was (Author: crocket):
    I assumed FacetsCollector.getFacetResults was a simple getter method, so I 
didn't optimize my code to call it once.

After discovering LUCENE-4893, I modified my code to call it once.

It may be a good idea to throw an exception or return am empty list if one 
calls it again.
There will be only so many lucene beginners with no knowledge of its side 
effects.
                  
> Facet counts in FacetsAccumulator.facetArrays are multiplied as many times as 
> FacetsCollector.getFacetResults is called.
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4893
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4893
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/facet
>    Affects Versions: 4.2
>            Reporter: crocket
>
> In lucene 4.1, only StandardFacetsAccumulator could be instantiated.
> And as of lucene 4.2, it became possible to instantiate FacetsAccumulator.
> I invoked FacetsCollector.getFacetResults twice, and I saw doubled facet 
> counts.
> If I invoke it three times, I see facet counts multiplied three times.
> It all happens in FacetsAccumulator.accumulate.
> StandardFacetsAccumulator doesn't have this bug since it frees facetArrays 
> whenever StandardFacetsAccumulator.accumulate is called.
> Is it a feature or a bug?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to