[
https://issues.apache.org/jira/browse/LUCENE-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618842#comment-13618842
]
Uwe Schindler commented on LUCENE-4877:
---------------------------------------
I have no preference on how to proceed. I just dont want to download such a
large patch, modify the sources and upload it again. especially as TortoiseSVN
and other clients depend on order of files in filesystem, the order of created
patches is different, too. So its impossible to see any change in comparison to
earlier patches.
As we don't intend to release trunk soon: If all tests patch, can you simply
commit as a first step, Robert? + on the current patch. We can open further
issues to unfuck ResourceLoaderAware (it should be removed, too and the
ResourceLoader should be passed to the ctor, too).
> Fix analyzer factories to throw exception when arguments are invalid
> --------------------------------------------------------------------
>
> Key: LUCENE-4877
> URL: https://issues.apache.org/jira/browse/LUCENE-4877
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/analysis
> Reporter: Robert Muir
> Attachments: LUCENE-4877_one_solution_prototype.patch,
> LUCENE-4877.patch, LUCENE-4877.patch, LUCENE-4877.patch
>
>
> Currently if someone typos an argument "someParamater=xyz" instead of
> someParameter=xyz, they get no exception and sometimes incorrect behavior.
> It would be way better if these factories threw exception on unknown params,
> e.g. they removed the args they used and checked they were empty at the end.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
