[ 
https://issues.apache.org/jira/browse/SOLR-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619784#comment-13619784
 ] 

Mark Miller commented on SOLR-4662:
-----------------------------------

Quick notes:

I don't think it has really morphed.

solr.xml has always been our only config file for the system or corecontainer 
level. Everything that has joined the corecontainer was added because it's not 
core level, and that's always been the role of solr.xml - home of the above 
SolrCore level.

Let's talk about the overall strategy before we nail down the impl.

IMO, solr.xml has a few issues:

1. It should not define cores. Solr should not have to write to this config 
file, and cores should be define by directory locations. 
2. The SolrCloud params are all cores attributes, but they should be in a 
better structure, similar to the shard handler definition that can now live in 
solr.xml, and what we do in solrconfig.xml.
3. We should consider how most of the solr.xml config can live in ZooKeeper 
when in SolrCloud mode. Much of this is not something you want to have to tweak 
on every node - it's going to be the same - you generally want to set a 
zkClientTimeout for your collection, not for each node. Same for shard handler. 
I think it's worth forcing some consistency for all nodes, such as the same 
host context. It will also be possible to override those things per node with 
sys prop notation. zkHost could no longer be specified in solr.xml.

So, I think we need to be able to detect and read the old solr.xml format some 
way (lot's of choices I think), as well as detect and read the new format 
(which will be very similar to the old). In 5 we stop supporting the old 
format. Example ships with the new format.

In terms of impl, I think you are on the right track. I don't think we should 
expose any user plugins at this point though. That should be internal work. 
Let's decide if we should support arbitrary impls for users later. It has an 
ongoing cost, in this area in particular I think. I think we want to reserve 
all API rights here.

                
> Finalize what we're going to do with solr.xml, auto-discovery, config sets.
> ---------------------------------------------------------------------------
>
>                 Key: SOLR-4662
>                 URL: https://issues.apache.org/jira/browse/SOLR-4662
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.3, 5.0
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Blocker
>
> Spinoff from SOLR-4615, breaking it out here so we can address the changes in 
> pieces.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to