[ 
https://issues.apache.org/jira/browse/LUCENE-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622113#comment-13622113
 ] 

Robert Muir commented on LUCENE-4874:
-------------------------------------

i think attributes() should be overridden by the Filter** by default. This is 
basically a getter.
                
> Don't override non abstract methods in FilterAtomicReader and related classes
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-4874
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4874
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-4874.patch
>
>
> Terms.intersect is an optional method. The fact that it is overridden in 
> FilterTerms forces any non-trivial class that extends FilterTerms to override 
> intersect in order this method to have a correct behavior. If FilterTerms did 
> not override this method and used the default impl, we would not have this 
> problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to