[
https://issues.apache.org/jira/browse/LUCENE-4902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623765#comment-13623765
]
Uwe Schindler commented on LUCENE-4902:
---------------------------------------
Hi, one thing to change (maybe):
In my opinion, the methods implemented by simply forwarding and calling
doWrapDirectoryReader(in.getReader) should be final, because the whole class
depends on this functionality. If you override these methods in a subclass
instead of correctly implementing the "SubReaderWrapper#wrap()" inner class and
"doWrapDirectoryReader()", you break the whole reopen logic. You should do the
work only in the abstract doWrapDirectoryReader() method is combination with
the SubReaderWrapper. So the methods for doOpenIfChanged(...) should be made
final to prevent mis-use.
> Add a FilterDirectoryReader
> ---------------------------
>
> Key: LUCENE-4902
> URL: https://issues.apache.org/jira/browse/LUCENE-4902
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-4902.patch, LUCENE-4902.patch
>
>
> A FilterDirectoryReader would allow you to easily wrap all subreaders of a
> DirectoryReader with FilterAtomicReaders.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
