[ 
https://issues.apache.org/jira/browse/LUCENE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624481#comment-13624481
 ] 

Michael McCandless commented on LUCENE-4903:
--------------------------------------------

bq. Since the asserting scorer delegates to the wrapped one, the asserting 
scorer gets lost, this is why Collector.setScorer tries to get it back by using 
a weak hash map.

OK I see.

Well I would just commit what you have now :)  We can improve the WeakHashMap 
solution if necessary later ... this is an awesome step forward.  Progress not 
perfection ...
                
> Add AssertingScorer
> -------------------
>
>                 Key: LUCENE-4903
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4903
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-4903.patch
>
>
> I think we would benefit from having an AssertingScorer that would assert 
> that scorers are advanced correctly, return valid scores (eg. not NaN), ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to