[ 
https://issues.apache.org/jira/browse/LUCENE-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625008#comment-13625008
 ] 

Michael McCandless commented on LUCENE-4885:
--------------------------------------------

bq. In general, I feel that FacetResult and FRN are too verbose. I think that 
the root node's statistics could be available from the FacetResult level, and 
that it could give you an iterator directly, rather than giving you a node 
which you always must call root.subResults... but it's for a separate issue.

I agree!

Also, sometimes you do need to pull a large number of facet results (the "See 
all..." case) ... and I wonder if we should just do parallel arrays, ie 
String[] labels and int[]/double[] values, for flat results, or only expose an 
iterator.

bq. Regarding TopKInEachNode, I wonder if we should eliminate that completely 
from FacetRequest, and create an appropriate FacetResultHander which you 
configure with the levels that you want, including (potentially, in the future) 
different K values for different levels?

+1
                
> each FacetResult should return the facet equivalent of totalHits
> ----------------------------------------------------------------
>
>                 Key: LUCENE-4885
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4885
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>              Labels: newdev
>             Fix For: 5.0, 4.3
>
>         Attachments: LUCENE-4885.patch, LUCENE-4885.patch
>
>
> This is cheap to compute, since the TopKFRH already must visit all 
> non-zero-count ords under the FacetRequest.categoryPath.
> This can be useful to a front end, eg to know whether to present a "More..." 
> under that dimension or not, whether to use a suggester like LinkedIn's facet 
> UI, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to