[ https://issues.apache.org/jira/browse/SOLR-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631807#comment-13631807 ]
Robert Muir commented on SOLR-3251: ----------------------------------- Hi Steve, I took a quick glance. One thing I don't quite understand: {quote} SchemaCodecFactory and SchemaSimilarityFactory don't change codec and similarity when the schema is swapped out: instead they refer to the latest version they have been inform()'d about. {quote} Can you elaborate on this (maybe just some code comments about which inform() gets called when)? I don't understand why there should be 2 inform methods or what its doing... ? Is the idea that these classes just need to be core-aware instead? And the SchemaAware interface is pretty much useless, except its being used now only as a marker to detect that the sim/codec understands properties on schema elements? Can we do something to eliminate the two inform methods? {quote} Schema is now effectively immutable: requests see the same schema snapshot for their lifetimes. {quote} well, except it seems for similarity (on indexsearcher)... which could be looking at the latest copy? > dynamically add field to schema > ------------------------------- > > Key: SOLR-3251 > URL: https://issues.apache.org/jira/browse/SOLR-3251 > Project: Solr > Issue Type: New Feature > Reporter: Yonik Seeley > Assignee: Steve Rowe > Attachments: SOLR-3251.patch, SOLR-3251.patch, SOLR-3251.patch, > SOLR-3251.patch > > > One related piece of functionality needed for SOLR-3250 is the ability to > dynamically add a field to the schema. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org