[ 
https://issues.apache.org/jira/browse/LUCENE-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632273#comment-13632273
 ] 

Robert Muir commented on LUCENE-4935:
-------------------------------------

Uwe: yes the bug is in 3.6 too: see CustomWeight's normalize (boost1)

{code}
    @Override
    public void normalize(float norm) {
      norm *= getBoost(); // incorporate boost
      subQueryWeight.normalize(norm);
{code}

and CustomScorer.score (boost2)

{code}
      return qWeight * provider.customScore(subQueryScorer.docID(), 
subQueryScorer.score(), vScores);
{code}

                
> CustomScoreQuery has broken boosting
> ------------------------------------
>
>                 Key: LUCENE-4935
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4935
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/query/scoring
>            Reporter: Robert Muir
>         Attachments: LUCENE-4935.patch
>
>
> CustomScoreQuery wrongly applies boost^2 instead of boost.
> It wrongly incorporates its boost into the normalization factor passed down 
> to subquery (like booleanquery does) and *also* multiplies it directly in its 
> scorer.
> The only reason the test passes today is because it compares raw score 
> magnitudes when querynorm is on, which normalizes this away.
> Changing the test to use newSearcher() demonstrates the brokenness.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to