Alan Woodward created SOLR-4735:
-----------------------------------

             Summary: Improve Solr metrics reporting
                 Key: SOLR-4735
                 URL: https://issues.apache.org/jira/browse/SOLR-4735
             Project: Solr
          Issue Type: Improvement
            Reporter: Alan Woodward
            Assignee: Alan Woodward
            Priority: Minor


Following on from a discussion on the mailing list:
http://search-lucene.com/m/IO0EI1qdyJF1/codahale&subj=Solr+metrics+in+Codahale+metrics+and+Graphite+

It would be good to make Solr play more nicely with existing devops monitoring 
systems, such as Graphite or Ganglia.  Stats monitoring at the moment is 
poll-only, either via JMX or through the admin stats page.  I'd like to 
refactor things a bit to make this more pluggable.

This patch is a start.  It adds a new interface, InstrumentedBean, which 
extends SolrInfoMBean to return a 
[[Metrics|http://metrics.codahale.com/manual/core/]] MetricRegistry, and a 
couple of MetricReporters (which basically just duplicate the JMX and admin 
page reporting that's there at the moment, but which should be more 
extensible).  The patch includes a change to RequestHandlerBase showing how 
this could work.  The idea would be to eventually replace the getStatistics() 
call on SolrInfoMBean with this instead.

The next step would be to allow more MetricReporters to be defined in 
solrconfig.xml.  The Metrics library comes with ganglia and graphite reporting 
modules, and we can add contrib plugins for both of those.

There's some more general cleanup that could be done around SolrInfoMBean 
(we've got two plugin handlers at /mbeans and /plugins that basically do the 
same thing, and the beans themselves have some weirdly inconsistent data on 
them - getVersion() returns different things for different impls, and 
getSource() seems pretty useless), but maybe that's for another issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to