[
https://issues.apache.org/jira/browse/SOLR-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636831#comment-13636831
]
Uwe Schindler commented on SOLR-2079:
-------------------------------------
I agree with Robert. We should pass the HttpServletRequest down with the Solr
params. The issue about calling getSession() is not our problem. For
Lucene-internal packages we should simply prevent this by adding the APIs to
the forbidden-apis signatures (we already have one for servlet-api.jar:
lucene/tools/forbiddenApis/servlet-api.txt). If somebody in a 3rd party plugin
calls getSession, its his problem. And there might be a valid use-case for
this! We just don't want to create sessions in Solr's code, so let's forbid
those APIs.
> Expose HttpServletRequest object from SolrQueryRequest object
> -------------------------------------------------------------
>
> Key: SOLR-2079
> URL: https://issues.apache.org/jira/browse/SOLR-2079
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers, search
> Reporter: Chris A. Mattmann
> Fix For: 4.3
>
> Attachments: SOLR-2079.patch, SOLR-2079.patch, SOLR-2079.patch,
> SOLR-2079.Quach.Mattmann.082310.patch.txt
>
>
> This patch adds the HttpServletRequest object to the SolrQueryRequest object.
> The HttpServletRequest object is needed to obtain the client's IP address for
> geotargetting, and is part of the patches from W. Quach and C. Mattmann.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
