[
https://issues.apache.org/jira/browse/LUCENE-4936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638005#comment-13638005
]
Robert Muir commented on LUCENE-4936:
-------------------------------------
+1: nice catch adrien.
Why do we have this logic for TABLE_COMPRESSED in diskdv consumer?
{code}
if (uniqueValues != null
&& ((maxValue - minValue) < 0L || (maxValue - minValue) > 256)
&& count <= Integer.MAX_VALUE) {
{code}
Shouldn't this just be:
{code}
if (uniqueValues != null && count <= Integer.MAX_VALUE) {
{code}
We only care about the number of unique values, but in this case it does not
matter what they actually are.
> docvalues date compression
> --------------------------
>
> Key: LUCENE-4936
> URL: https://issues.apache.org/jira/browse/LUCENE-4936
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Robert Muir
> Assignee: Adrien Grand
> Fix For: 4.4
>
> Attachments: LUCENE-4936.patch, LUCENE-4936.patch, LUCENE-4936.patch,
> LUCENE-4936.patch, LUCENE-4936.patch, LUCENE-4936.patch, LUCENE-4936.patch,
> LUCENE-4936.patch
>
>
> DocValues fields can be very wasteful if you are storing dates (like solr's
> TrieDateField does if you enable docvalues) and don't actually need all the
> precision: e.g. "date-only" fields like date of birth with no time component,
> time fields without milliseconds precision, and so on.
> Ideally we'd compute GCD of all the values to save space
> (numberOfTrailingZeros is not really enough here), but i think we should at
> least look for values like 86400000, 3600000, and 1000 to be practical.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
