[
https://issues.apache.org/jira/browse/LUCENE-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-4963:
---------------------------------
Attachment: LUCENE-4963.patch
Thanks Uwe for the advice. Here is a first patch:
* Deprecate constructors that expose broken options and make them throw an
IllegalArgumentException when the lucene match version is >= 4.4
* Remove the same constructors from TestRandomChains' exclusion list.
* Since enablePositionIncrements=true was used by the Analyzing and Fuzzy
suggesters to ignore position holes, I had to make it an option in the
suggesters themselves instead of the token streams.
* More documentation in the oal.analysis package: PositionLengthAttribute and
guidelines on writing non-corrupt token streams.
> Deprecate broken TokenFilter constructors
> -----------------------------------------
>
> Key: LUCENE-4963
> URL: https://issues.apache.org/jira/browse/LUCENE-4963
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Fix For: 4.4
>
> Attachments: LUCENE-4963.patch
>
>
> We have some TokenFilters which are only broken with specific options. This
> includes:
> * TrimFilter when updateOffsets=true
> * StopFilter, JapanesePartOfSpeechStopFilter, KeepWordFilter, LengthFilter,
> TypeTokenFilter when enablePositionIncrements=false
> I think we should deprecate these behaviors in 4.4 and remove them in trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
