[
https://issues.apache.org/jira/browse/LUCENE-4965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645375#comment-13645375
]
Shai Erera commented on LUCENE-4965:
------------------------------------
Awesome! And thanks for adding the examples!
In TestRangeAccumulator:
* You don't use LongRange.accept (for expected counts) b/c that's what you test
right? maybe just drop a one liner?
* Also, does the test really need to run atLeast(100) iters? I would think one
iteration is enough, if we let Jenkins periodic builds do the iters for us
(plus, someone can run with -Dtests.iters or -Dtests.dups)
* These apply to all 4 random test methods.
In RangeAccumulator:
* I think you can remove "nocommit add to example"?
* There are some leftover commented out lines (members and ctor)
In the example:
* new Date().getTime() can be just System.currentTimeMillis()?
* Also, do we really need to index 1000 documents to demo? I ask because it's
harder to debug 1000 docs :)
I'm +1 to commit, no need to upload a new patch from my side.
> Add dynamic numeric range faceting
> ----------------------------------
>
> Key: LUCENE-4965
> URL: https://issues.apache.org/jira/browse/LUCENE-4965
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, 4.4
>
> Attachments: LUCENE-4965.patch, LUCENE-4965.patch, LUCENE-4965.patch,
> LUCENE-4965.patch, LUCENE-4965.patch, LUCENE-4965.patch, LUCENE-4965.patch,
> LUCENE-4965.patch
>
>
> The facet module today requires the app to compute the hierarchy
> at index time, eg a timestamp field might use a year/month/day
> hierarchy.
> While this gives great performance, since it minimizes the search-time
> computation, sometimes it's unfortunately useful/necessary to do things
> entirely at
> search time, like Solr does.
> E.g. I'm playing with a prototype Lucene search for Jira issues
> and I'd like to add a drill down+sideways for "Updated in past day,
> 2 days, week, month" etc. But because time is constantly advancing,
> doing this at index time is a not easy ...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
