[ 
https://issues.apache.org/jira/browse/LUCENE-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645378#comment-13645378
 ] 

Adrien Grand commented on LUCENE-4963:
--------------------------------------

Hi Uwe, thanks for doing the review! The patch applies to trunk and I plan to 
remove deprecations in a second step. Is it OK with you?
                
> Deprecate broken TokenFilter constructors
> -----------------------------------------
>
>                 Key: LUCENE-4963
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4963
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>             Fix For: 4.4
>
>         Attachments: LUCENE-4963.patch
>
>
> We have some TokenFilters which are only broken with specific options. This 
> includes:
>  * TrimFilter when updateOffsets=true
>  * StopFilter, JapanesePartOfSpeechStopFilter, KeepWordFilter, LengthFilter, 
> TypeTokenFilter when enablePositionIncrements=false
> I think we should deprecate these behaviors in 4.4 and remove them in trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to