[ 
https://issues.apache.org/jira/browse/LUCENE-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649702#comment-13649702
 ] 

Robert Muir commented on LUCENE-4982:
-------------------------------------

Its not clear to me if with the patch we will double-count against disk full if 
copyBytes calls writeBytes behind the scenes...

Maybe we can make the test have a max size of 2 bytes and copyBytes twice to it 
just so this is obvious?
                
> Make MockIndexOutputWrapper check disk full on copyBytes
> --------------------------------------------------------
>
>                 Key: LUCENE-4982
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4982
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/test-framework
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-4982.patch
>
>
> While working on the consistency test for Replicator (LUCENE-4975), I noticed 
> that I don't trip disk-full exceptions and tracked it down to 
> MockIndexOutputWrapper.copyBytes not doing these checks like writeBytes. I'd 
> like to add this check.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to