[ 
https://issues.apache.org/jira/browse/SOLR-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650885#comment-13650885
 ] 

Shawn Heisey commented on SOLR-4358:
------------------------------------

[~kamaci] I've checked the 4.3.0 source and this patch did not make it in there.

Looking through the commit history and the issue notes, what happened is this: 
An initial patch was created and committed on April 16th.  That commit included 
the entry in CHANGES.txt.  It was quickly discovered that this didn't fix the 
issue, so the code change was reverted - but the entry in CHANGES.txt got left 
behind.  The 4.3 code branch was created on April 17th.  On April 19th, the 
true fix for this issue was committed to trunk and the 4x branch.

The CHANGES.txt for 4.3.0 is unfortunately wrong - the fix is NOT in 4.3.

                
> SolrJ, by preventing multi-part post, loses key information about file name 
> that Tika needs
> -------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4358
>                 URL: https://issues.apache.org/jira/browse/SOLR-4358
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 4.0
>            Reporter: Karl Wright
>            Assignee: Ryan McKinley
>             Fix For: 5.0, 4.4
>
>         Attachments: additional_changes.diff, SOLR-4358.patch, 
> SOLR-4358.patch, SOLR-4358.patch
>
>
> SolrJ accepts a ContentStream, which has a name field.  Within 
> HttpSolrServer.java, if SolrJ makes the decision to use multipart posts, this 
> filename is transmitted as part of the form boundary information.  However, 
> if SolrJ chooses not to use multipart post, the filename information is lost.
> This information is used by SolrCell (Tika) to make decisions about content 
> extraction, so it is very important that it makes it into Solr in one way or 
> another.  Either SolrJ should set appropriate equivalent headers to send the 
> filename automatically, or it should force multipart posts when this 
> information is present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to