[
https://issues.apache.org/jira/browse/LUCENE-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651179#comment-13651179
]
Michael McCandless commented on LUCENE-4980:
--------------------------------------------
bq. I think the TODO is a bit trickier than what it writes ... you cannot
decide to create SortedSetDVAccumulator based on a FacetRequest.
Hmm true. Maybe we need a separate SSDVFacetRequest? Not sure ...
I don't think I'll remove the TODO: I think it's still important that (somehow)
we are able to send an FSP requiring different FacetsAccumulators and something
figures out which ones to instantiate, and then collates the FacetResults back
in order, somehow ... I will fixup the TODO to reflect its difficulty though :)
> Can't use DrillSideways with both RangeFacetRequest and non-RangeFacetRequest
> -----------------------------------------------------------------------------
>
> Key: LUCENE-4980
> URL: https://issues.apache.org/jira/browse/LUCENE-4980
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, 4.4
>
> Attachments: LUCENE-4980.patch, LUCENE-4980.patch
>
>
> I tried to combine these two and there were several issues:
> * It's ... really tricky to manage the two different
> FacetAccumulators across that N FacetCollectors that DrillSideways
> creates ... to fix this I added a new MultiFacetsAccumulator that
> switches for you.
> * There was still one place in DS/DDQ that wasn't properly handling
> a non-Term drill-down.
> * There was a bug in the "collector method" for DrillSideways
> whereby if a given segment had no hits, it was skipped, which is
> incorrect because it must still be visited to tally up the
> sideways counts.
> * Separately I noticed that DrillSideways was doing too much work:
> it would count up drill-down counts *and* drill-sideways counts
> against the same dim (but then discard the drill-down counts in
> the end).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
