[ 
https://issues.apache.org/jira/browse/SOLR-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652188#comment-13652188
 ] 

Uwe Schindler edited comment on SOLR-4791 at 5/8/13 6:37 PM:
-------------------------------------------------------------

Thanks for referring to my Schindler-hack in the comment! I did this the same 
way in forbidden-apis, so the hack comes from there: 
[https://code.google.com/p/forbidden-apis/source/browse/trunk/src/main/java/de/thetaphi/forbiddenapis/AbstractCheckMojo.java?r=153#229]

So I told this Robert privately (was on phone) how to handle URLClassLoader 
without reflecting methods. The addition of the Closeable interface to 
URLClassLoader is one of the "important" Java 7 bug fixes, which is also listed 
in Java 7's release notes (which was added to make e.g. Tomcat be able to 
remove the JAR files of a webapp when redeploying them on a windows 
container...).
                
      was (Author: thetaphi):
    Thanks for referring to my Schindler-hack in the comment! I did this the 
same way in forbidden-apis, so the hack comes from there: 
[https://code.google.com/p/forbidden-apis/source/browse/trunk/src/main/java/de/thetaphi/forbiddenapis/AbstractCheckMojo.java#229]

So I told this Robert privately (was on phone) how to handle URLClassLoader 
without reflecting methods. The addition of the Closeable interface to 
URLClassLoader is one of the "important" Java 7 bug fixes, which is also listed 
in Java 7's release notes (which was added to make e.g. Tomcat be able to 
remove the JAR files of a webapp when redeploying them on a windows 
container...).
                  
> solr.xml sharedLib does not work in 4.3.0
> -----------------------------------------
>
>                 Key: SOLR-4791
>                 URL: https://issues.apache.org/jira/browse/SOLR-4791
>             Project: Solr
>          Issue Type: Bug
>          Components: multicore
>    Affects Versions: 4.3
>            Reporter: Jan Høydahl
>            Assignee: Erick Erickson
>             Fix For: 5.0, 4.4, 4.3.1
>
>         Attachments: closeLoader.patch, SOLR-4791.patch, SOLR-4791.patch, 
> SOLR-4791.patch, SOLR-4791-test.patch
>
>
> The sharedLib attribute on {{<solr>}} tag in solr.xml stopped working in 4.3.
> Using old-style solr.xml with sharedLib defined on solr tag. Solr does not 
> load any of them. Simply swapping out solr.war with the 4.2.1 one, brings 
> sharedLib loading back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to