[
https://issues.apache.org/jira/browse/LUCENE-4990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652851#comment-13652851
]
Michael McCandless commented on LUCENE-4990:
--------------------------------------------
+1
But, I rather liked the comment "corrumpt..." :)
Also, can you factor out that large instanceof if into a separate method, eg
named "mustSync" or something, with a comment explaining that certain dir impls
require sync'ing? If we add future wrapping dir impls we need to update this
method ...
> Improve MockDirectoryWrapper.sync
> ---------------------------------
>
> Key: LUCENE-4990
> URL: https://issues.apache.org/jira/browse/LUCENE-4990
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/test-framework
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Attachments: LUCENE-4990.patch
>
>
> Currently MockDirWrapper always calls delegate.sync() with a comment that we
> can relax this to not wear out the hardware for tests. The issue, as
> discussed on this thread http://lucene.markmail.org/thread/eozdsbdahzhjvizj,
> is related to NRTCachingDirectory and RateLimiter. The improvements I'd like
> to make under this issue are:
> * Call delgeate.sync() if:
> ** rarely()
> ** delegate is NRTCachingDir
> ** delegate is RateLimitedDirWrapper and its delegate is NRTCachingDir
> ** delegate is TrackingDirWrapper and its delegate is NRTCachingDir
> * Also, today the method either fails to sync all files or succeeds. Rather,
> we can improve this to randomly throw IOE on each file.
> Any other Directories that can cause issues when sync() isn't called?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
