[
https://issues.apache.org/jira/browse/SOLR-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar resolved SOLR-1393.
-----------------------------------------
Resolution: Won't Fix
Fix Version/s: (was: 4.4)
Marking this as won't fix per discussion on IRC:
{quote}
[11:07] <shalin> vkirilchuk: about SOLR-1393 -- I'm not sure if it's so useful
[11:08] <vkirilchuk> Yes, me too, so i asked Grant to provide usecases.
[11:08] <vkirilchuk> But it's an interesting tak itself
[11:08] <vkirilchuk> tak=task
[11:09] <shalin> yeah it is useful until you have a couple of such declaration
but beyond that even users will have a problem keeping the order in their head
[11:09] <shalin> better to just write down all the components if you want
strict ordering
[11:09] <@gsingers> That stuff is probably better handled by Guice injection,
shalin and vkirilchuk
[11:10] <vkirilchuk> agree with shalin
[11:10] <vkirilchuk> solr has no DI, so...
[11:10] <shalin> gsingers: one day, one day for sure! :)
[11:11] <vkirilchuk> Anyway i implemented a draft. You need to reorder all
components according to before and after dependencies
[11:11] <@gsingers> I think when I opened that the main issue had to do w/
right now we only have a way of saying before everything or after everything OR
explicitly declare everything
[11:11] <@gsingers> feel free to close it
[11:11] <vkirilchuk> and that can be done by using Topological Sorting of
Direct Acyclic Graph
[11:12] <@gsingers> We really need to get Guice going for plugins
[11:12] <@gsingers> as it would simplify a lot
[11:12] <vkirilchuk> +1
[11:15] <vkirilchuk> I am not a commiter so i can't close the issues. Anyway
making things with direct acyclic graph is over complex in my opinion.
[11:16] <vkirilchuk> But with it you can really add constraints like component
(after query, before facet, debug)
[11:17] <vkirilchuk> and it will order your components according to all
dependencies between them)
[11:18] <shalin> yes, we shouldn't add this much complexity. I'll close the
issue.
{quote}
> Allow more control over SearchComponents ordering in SearchHandler
> ------------------------------------------------------------------
>
> Key: SOLR-1393
> URL: https://issues.apache.org/jira/browse/SOLR-1393
> Project: Solr
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Priority: Minor
> Labels: newdev
>
> It would be useful to be able to add the notion of before/after when
> declaring search components. Currently, you can either explicitly declare
> all components or insert at the beginning or end. It would be nice to be
> able to say: this new component comes after the Query component without
> having to declare all the components.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
