[ 
https://issues.apache.org/jira/browse/SOLR-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated SOLR-4810:
--------------------------------

    Description: 
All Windows Jenkins runs fail because the following SolrJ tests hit a bug:

- 
org.apache.solr.client.solrj.embedded.TestEmbeddedSolrServer.testGetCoreContainer
- org.apache.solr.client.solrj.embedded.TestEmbeddedSolrServer.testShutdown
- org.apache.solr.client.solrj.embedded.TestSolrProperties.testProperties
- org.apache.solr.client.solrj.request.TestCoreAdmin.testCustomUlogDir
- org.apache.solr.client.solrj.request.TestCoreAdmin.testErrorCases

The Exception is: 

{noformat}
Caused by: java.io.IOException: The filename, directory name, or volume label 
syntax is incorrect
        at java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.io.Win32FileSystem.canonicalize(Win32FileSystem.java:414)
        at java.io.File.getCanonicalPath(File.java:589)
        at 
org.apache.solr.core.ConfigSolrXmlOld.initCoreList(ConfigSolrXmlOld.java:185)
        at 
org.apache.solr.core.ConfigSolrXmlOld.<init>(ConfigSolrXmlOld.java:63)
        at org.apache.solr.core.CoreContainer.load(CoreContainer.java:256)
        ... 40 more
{noformat}

I added a System.err.println: the new File(instDir, dataDir) call in 
ConfigSolrXmlOld.java:185 produces the following file name:
{noformat}
"${theInstanceDir:.\}\${dataDir1}"
{noformat}

This does not fail on Linux/MacOS because the filesystems there don't care 
about $ and { symbols, but I am glad that Windows found that bug, because there 
is clearly a property expansion missing.

  was:
All Windows Jenkins runs fail because the following SolrJ tests hit a bug:

- 
org.apache.solr.client.solrj.embedded.TestEmbeddedSolrServer.testGetCoreContainer
- org.apache.solr.client.solrj.embedded.TestEmbeddedSolrServer.testShutdown
- org.apache.solr.client.solrj.embedded.TestSolrProperties.testProperties
- org.apache.solr.client.solrj.request.TestCoreAdmin.testCustomUlogDir
- org.apache.solr.client.solrj.request.TestCoreAdmin.testErrorCases

The Exception is: 

{noformat}
Caused by: java.io.IOException: The filename, directory name, or volume label 
syntax is incorrect
        at java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.io.Win32FileSystem.canonicalize(Win32FileSystem.java:414)
        at java.io.File.getCanonicalPath(File.java:589)
        at 
org.apache.solr.core.ConfigSolrXmlOld.initCoreList(ConfigSolrXmlOld.java:185)
        at 
org.apache.solr.core.ConfigSolrXmlOld.<init>(ConfigSolrXmlOld.java:63)
        at org.apache.solr.core.CoreContainer.load(CoreContainer.java:256)
        ... 40 more
{noformat}

I added a System.err.println: the new File(instDir, dataDir) call in 
ConfigSolrXmlOld.java:185 produces the following file name:  
"${theInstanceDir:.\}\${dataDir1}"

This does not fail on Linux/MacOS because the filesystems there don't care 
about $ and { symbols, but I am glad that Windows found that bug, because there 
is clearly a property expansion missing.

    
> Various SolrJ tests fail on windows because missing property expansion (on 
> Linux, too - but causes no error)
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4810
>                 URL: https://issues.apache.org/jira/browse/SOLR-4810
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>            Reporter: Uwe Schindler
>            Priority: Critical
>
> All Windows Jenkins runs fail because the following SolrJ tests hit a bug:
> - 
> org.apache.solr.client.solrj.embedded.TestEmbeddedSolrServer.testGetCoreContainer
> - org.apache.solr.client.solrj.embedded.TestEmbeddedSolrServer.testShutdown
> - org.apache.solr.client.solrj.embedded.TestSolrProperties.testProperties
> - org.apache.solr.client.solrj.request.TestCoreAdmin.testCustomUlogDir
> - org.apache.solr.client.solrj.request.TestCoreAdmin.testErrorCases
> The Exception is: 
> {noformat}
> Caused by: java.io.IOException: The filename, directory name, or volume label 
> syntax is incorrect
>       at java.io.WinNTFileSystem.canonicalize0(Native Method)
>       at java.io.Win32FileSystem.canonicalize(Win32FileSystem.java:414)
>       at java.io.File.getCanonicalPath(File.java:589)
>       at 
> org.apache.solr.core.ConfigSolrXmlOld.initCoreList(ConfigSolrXmlOld.java:185)
>       at 
> org.apache.solr.core.ConfigSolrXmlOld.<init>(ConfigSolrXmlOld.java:63)
>       at org.apache.solr.core.CoreContainer.load(CoreContainer.java:256)
>       ... 40 more
> {noformat}
> I added a System.err.println: the new File(instDir, dataDir) call in 
> ConfigSolrXmlOld.java:185 produces the following file name:
> {noformat}
> "${theInstanceDir:.\}\${dataDir1}"
> {noformat}
> This does not fail on Linux/MacOS because the filesystems there don't care 
> about $ and { symbols, but I am glad that Windows found that bug, because 
> there is clearly a property expansion missing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to