[
https://issues.apache.org/jira/browse/LUCENE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655415#comment-13655415
]
Steve Rowe commented on LUCENE-4955:
------------------------------------
{quote}
Steve, I don't think we should do this unless we add a Version.LUCENE_4_3_1.
The problem here is that this filter would introduce a totally different
behaviour compared to the 4.3 version that we released. If you build your index
with 4.3 you would need to reindex if you switch to 4.3.1 unless we add the
version so we can fallback on the old behaviour. Makes sense?
{quote}
I agree, Simon. I'll remove the lucene-4.3.1-candidate label.
> NGramTokenFilter increments positions for each gram
> ---------------------------------------------------
>
> Key: LUCENE-4955
> URL: https://issues.apache.org/jira/browse/LUCENE-4955
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/analysis
> Affects Versions: 4.3
> Reporter: Simon Willnauer
> Assignee: Adrien Grand
> Labels: lucene-4.3.1-candidate
> Fix For: 5.0, 4.4
>
> Attachments: highlighter-test.patch, highlighter-test.patch,
> LUCENE-4955.patch, LUCENE-4955.patch
>
>
> NGramTokenFilter increments positions for each gram rather for the actual
> token which can lead to rather funny problems especially with highlighting.
> if this filter should be used for highlighting is a different story but today
> this seems to be a common practice in many situations to highlight sub-term
> matches.
> I have a test for highlighting that uses ngram failing with a StringIOOB
> since tokens are sorted by position which causes offsets to be mixed up due
> to ngram token filter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
