[
https://issues.apache.org/jira/browse/SOLR-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656517#comment-13656517
]
Shawn Heisey commented on SOLR-3038:
------------------------------------
bq. One approach would be to detect the server version and fall back to XML if
its javabin is known to be incompatible.
[~sokolov] I have been thinking about this since you suggested it. The idea
itself is very good, I just think there are too many things that could go wrong.
At this moment, I think that detection really belongs in the user app code.
The particular way that you have found for detecting 3.x (looking for the
old-style admin) would fail if the user has taken steps to block access to the
admin interface - it would think it's dealing with a 4.x server, which wouldn't
work.
Even if we found a completely reliable way of detecting whether XML is required
(that couldn't be blocked accidentally or intentionally) it would still involve
making a request to the server that the app developer did not explicitly put in
their code. Also, creating the server object might be conditional on the
server being up at that moment, a requirement that does not exist today.
I'm the new kid on the Solr committer block. The veterans may feel differently
about your idea. I'm willing to try coding the detection idea, look for an
alternate patch soon.
> Solrj should use javabin wireformat by default with updaterequests
> ------------------------------------------------------------------
>
> Key: SOLR-3038
> URL: https://issues.apache.org/jira/browse/SOLR-3038
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 4.0-ALPHA
> Reporter: Sami Siren
> Priority: Minor
> Attachments: SOLR-3038-abstract-writer.patch,
> SOLR-3038-abstract-writer.patch, SOLR-3038-abstract-writer.patch,
> SOLR-3038-abstract-writer.patch, SOLR-3038-abstract-writer.patch
>
>
> The javabin wire format is faster than xml when feeding Solr - it should
> become the default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
