Here's lucene/build.xml$check-licenses - nothing in there about the servlet api
jar?:
-----
<target name="check-licenses" depends="compile-tools,resolve,load-custom-tasks"
description="Validate license stuff.">
<license-check-macro dir="${basedir}" licensedir="${common.dir}/licenses">
<additional-filters>
<replaceregex pattern="jetty([^/]+)$" replace="jetty" flags="gi" />
<replaceregex pattern="slf4j-([^/]+)$" replace="slf4j" flags="gi" />
<replaceregex pattern="(bcmail|bcprov)-([^/]+)$" replace="\1" flags="gi"
/>
</additional-filters>
</license-check-macro>
</target>
-----
Steve
On May 15, 2013, at 4:58 AM, Shai Erera <[email protected]> wrote:
> I added something like that to lucene/build.xml$check-licenses. Perhaps we
> should add the same to validate-maven-dependencies?
>
> Shai
>
>
> On Wed, May 15, 2013 at 11:33 AM, Steve Rowe <[email protected]> wrote:
> Looks like the Solr build is just ignoring the servlet jar for the purposes
> of license/checksum validation - from solr/common-build.xml:
>
> -----
> <target name="-validate-maven-dependencies"
> depends="-validate-maven-dependencies.init">
> <m2-validate-dependencies pom.xml="${maven.pom.xml}"
> licenseDirectory="${license.dir}">
> <additional-filters>
> <replaceregex pattern="jetty([^/]+)$" replace="jetty" flags="gi" />
> <replaceregex pattern="slf4j-([^/]+)$" replace="slf4j" flags="gi" />
> <replaceregex pattern="(bcmail|bcprov)-([^/]+)$" replace="\1"
> flags="gi" />
> </additional-filters>
> <excludes>
> <rsel:or>
> <rsel:name name="**/lucene-*-${maven.version.glob}.jar"
> handledirsep="true"/>
> <rsel:name name="**/solr-*-${maven.version.glob}.jar"
> handledirsep="true"/>
> <!-- TODO: figure out what is going on here with servlet-apis -->
> <rsel:name name="**/*servlet*.jar" handledirsep="true"/>
> </rsel:or>
> </excludes>
> </m2-validate-dependencies>
> </target>
> -----
>
> Steve
>
> On May 15, 2013, at 4:25 AM, Shai Erera <[email protected]> wrote:
>
> > I copied the replicator's ivy dependencies from Solr's. In
> > replicator/build.xml you can find the copy/renaming thing,
> > I think that I tried also without it, but something else broke, I don't
> > remember what though.
> >
> > So the question is I guess, how does the maven dependency check passes for
> > Solr?
> >
> > Shai
> >
> >
> > On Wed, May 15, 2013 at 11:08 AM, Steve Rowe <[email protected]> wrote:
> > Shai,
> >
> > As I mentioned in another email thread, the Ant+Ivy setup for the
> > replicator module renames remote dependency
> > javax.servlet-3.0.0.v201112011016.jar to local filename servlet-api-3.0.jar
> > - I don't know how or why. As a result, the checksum, license and notice
> > files in lucene/licenses/ are named servlet-api-*.
> >
> > Maven has no such renaming facility, so the dependency name is the same as
> > the remote file name, and the checksum checker, for which there is no
> > mapping facility, expects the .sha1 file to be the dependency filename with
> > ".sha1" appended. That's why this file is required, not by Maven, but by
> > the Ant build's 'validate-maven-dependencies' target.
> >
> > Steve
> >
> >
> > On May 15, 2013, at 3:57 AM, Shai Erera <[email protected]> wrote:
> >
> > > Steve, I discussed this w/ Robert before I removed the file.
> > >
> > > Robert explained me that "jar-checksums" removes any license files that
> > > without a matching .jar and then "check-svn-working-copy" reports a dirty
> > > checkout.
> > >
> > >
> > > Why is this file required by maven?
> > >
> > > At any rate, I don't understand what's going on either. Whatever fixes
> > > this, I'm fine with
> > >
> > > Shai
> > >
> > >
> > > On Wed, May 15, 2013 at 10:41 AM, Steve Rowe <[email protected]> wrote:
> > > Shai, that .sha1 file was not leftover - I just added it.
> > >
> > > After you removed it, I now get the following from 'ant
> > > validate-maven-dependencies':
> > >
> > > -----
> > > -validate-maven-dependencies:
> > > [licenses] MISSING sha1 checksum file for:
> > > /Users/sarowe/.m2/repository/org/eclipse/jetty/orbit/javax.servlet/3.0.0.v201112011016/javax.servlet-3.0.0.v201112011016.jar
> > > [licenses] Scanned 14 JAR file(s) for licenses (in 0.05s.), 1 error(s).
> > > -----
> > >
> > > I don't understand why this file is being reported as causing a dirty
> > > checkout (see quoted error message below) - I looked at the groovy script
> > > that does this checking, and this particular message is given when a file
> > > is either unversioned or missing. Neither condition should be true in
> > > this case.
> > >
> > > Uwe, do you understand what's going on here?
> > >
> > > Steve
> > >
> > > On May 15, 2013, at 1:09 AM, Shai Erera <[email protected]> wrote:
> > >
> > > > Removed the leftover license file.
> > > >
> > > > Shai
> > > >
> > > > On Wed, May 15, 2013 at 7:24 AM, Policeman Jenkins Server
> > > > <[email protected]> wrote:
> > > > Build: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Linux/5661/
> > > > Java: 64bit/jdk1.8.0-ea-b86 -XX:+UseCompressedOops -XX:+UseSerialGC
> > > […]
> > > > BUILD FAILED
> > > > /mnt/ssd/jenkins/workspace/Lucene-Solr-trunk-Linux/build.xml:377: The
> > > > following error occurred while executing this line:
> > > > /mnt/ssd/jenkins/workspace/Lucene-Solr-trunk-Linux/build.xml:316: The
> > > > following error occurred while executing this line:
> > > > /mnt/ssd/jenkins/workspace/Lucene-Solr-trunk-Linux/extra-targets.xml:122:
> > > > Source checkout is dirty after running tests!!! Offending files:
> > > > * lucene/licenses/javax.servlet-3.0.0.v201112011016.jar.sha1
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [email protected]
> > > For additional commands, e-mail: [email protected]
> > >
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [email protected]
> > For additional commands, e-mail: [email protected]
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
