Thanks Mike! I had arrived at the same fix, but didnt' commit because the smoke tester was also complaining (after running for 30 minutes) about Solr's NOTICE.txt not having a verbatim copy of Lucene's NOTICE.txt - this is as a result of my changing the text in Lucene's NOTICE.txt about servlet-api.jar to include javax.servlet-*.jar.
Tracking down why this was still true after copy/pasting Lucene's into Solr's took a while - after I had the smoke tester print out the things it was comparing, I realized that it wasn't comparing my local changes, but rather the committed changes… Anyway, I've committed a change to Solr's NOTICE.txt to make it a verbatim copy of Lucene's NOTICE.txt, and I'm running the smoke tester again after committing. Steve On May 16, 2013, at 1:19 PM, mikemcc...@apache.org wrote: > Author: mikemccand > Date: Thu May 16 17:18:59 2013 > New Revision: 1483459 > > URL: http://svn.apache.org/r1483459 > Log: > allow javax.servlet exception in lucene/replicator > > Modified: > lucene/dev/trunk/dev-tools/scripts/smokeTestRelease.py > > Modified: lucene/dev/trunk/dev-tools/scripts/smokeTestRelease.py > URL: > http://svn.apache.org/viewvc/lucene/dev/trunk/dev-tools/scripts/smokeTestRelease.py?rev=1483459&r1=1483458&r2=1483459&view=diff > ============================================================================== > --- lucene/dev/trunk/dev-tools/scripts/smokeTestRelease.py (original) > +++ lucene/dev/trunk/dev-tools/scripts/smokeTestRelease.py Thu May 16 > 17:18:59 2013 > @@ -265,6 +265,9 @@ def checkAllJARs(topDir, project, svnRev > if normRoot.endswith('/contrib/dataimporthandler/lib') and > (file.startswith('mail-') or file.startswith('activation-')): > print(' **WARNING**: skipping check of %s/%s: it has javax.* > classes' % (root, file)) > continue > + else: > + if normRoot.endswith('/replicator/lib') and > file.startswith('javax.servlet'): > + continue > fullPath = '%s/%s' % (root, file) > noJavaPackageClasses('JAR file "%s"' % fullPath, fullPath) > if file.lower().find('lucene') != -1 or file.lower().find('solr') != > -1: > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
