[ 
https://issues.apache.org/jira/browse/SOLR-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663162#comment-13663162
 ] 

Erik Hatcher commented on SOLR-4842:
------------------------------------

bq. Ugh ... i didn't realize how stateful param parsing had gotten i nthe 
faceting code.

Yeah, icky it is.

bq. Erik's last patch had at least one bug remaining that affected range & date 
faceting because of the need to reset the "required" params.

Hmmm... did you see a test failure?   I was wondering if that change you made 
was needed at the time but no tests were failing.  I added your one-line tweak 
in there.  If you added test cases in your patch I didn't catch that yet.  

Committed to branch_4x and trunk.  Is there any other branch where this should 
go?
                
> Field faceting with local params affects successive field faceting parameters
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-4842
>                 URL: https://issues.apache.org/jira/browse/SOLR-4842
>             Project: Solr
>          Issue Type: Bug
>          Components: search, SearchComponents - other
>    Affects Versions: 4.3
>            Reporter: Erik Hatcher
>            Assignee: Erik Hatcher
>            Priority: Critical
>             Fix For: 5.0, 4.3.1
>
>         Attachments: SOLR-4842__hoss_tests.patch, SOLR-4842.patch, 
> SOLR-4842.patch, SOLR-4842.patch, SOLR-4842.patch
>
>
> SOLR-4717 introduced local param support for per-field faceting, allowing the 
> same field to be faceted in various ways.  There's a problem such that one 
> fields local param setting will override the defaults of the next field.  For 
> example: 
> {code}http://localhost:8983/solr/query?q=*:*&facet=true&rows=0&facet.field={!facet.prefix=a}name&facet.field=features{code}
>  where the facet.prefix for name affects the features faceting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to