[
https://issues.apache.org/jira/browse/SOLR-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664831#comment-13664831
]
Shalin Shekhar Mangar commented on SOLR-4745:
---------------------------------------------
+1
> Do not pass a SolrCore in ZkController.preRegister()
> ----------------------------------------------------
>
> Key: SOLR-4745
> URL: https://issues.apache.org/jira/browse/SOLR-4745
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 4.4
>
> Attachments: SOLR-4745.patch
>
>
> The shard splitting feature changed the method definition of
> ZkController#preRegister to accept a SolrCore instead of CoreDescriptor.
> From the comments in SOLR-3755:
> bq. Set update log to buffering mode before it is published (fixes bug with
> extra doc count on sub-shard)
> bq. Regarding those changes - I'd really like to find another way to do that.
> The original change around this made preRegister start taking a core rather
> than a core descriptor. I'd like to work that out so it doesn't need to be
> the case. That is where the core will find out some of it's properties (shard
> id, core node name, perhaps more in the future). It would be nice if the core
> init code had access to this information - so it would be nice if we could
> call preRegister (or some refactored version) before actually creating the
> SolrCore.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
