Rob, personally I don't mind if SLF4J goes out ... the whole jetty dependencies is required only for testing at the moment. The question is, if you take it out, will we still be able to debug what's going on during tests on the Jetty side? Will Jetty dump everything it has to syserr if SLF4J is not present?
Shai On Thu, May 23, 2013 at 5:38 AM, Robert Muir <rcm...@gmail.com> wrote: > I looked at this: i dont think this module should rely upon slf4j. > > Remember all this jetty stuff, is just for running this test. > Jetty doesnt need slf4j (it just goes to system.err.println by default if > slf4j isnt there), so slf4j is only making things worse. > the only thing here that needs logging jars is the httpclient, and because > of that unfortunately commons-logging is needed. > > Fixing these dependencies makes the test log correctly. Still, bringing in > all this jetty etc is a really heavy-duty way to test. It would be better > to test this module without dragging in so many third party dependencies. > > Index: ivy.xml > =================================================================== > --- ivy.xml (revision 1485538) > +++ ivy.xml (working copy) > @@ -39,8 +39,7 @@ > <dependency org="org.eclipse.jetty" name="jetty-io" > rev="&jetty.version;" transitive="false" conf="jetty->default"/> > <dependency org="org.eclipse.jetty" name="jetty-continuation" > rev="&jetty.version;" transitive="false" conf="jetty->default"/> > <dependency org="org.eclipse.jetty" name="jetty-http" > rev="&jetty.version;" transitive="false" conf="jetty->default"/> > - <dependency org="org.slf4j" name="slf4j-api" rev="1.6.6" > transitive="false" conf="logging->default"/> > - <dependency org="org.slf4j" name="jcl-over-slf4j" rev="1.6.6" > transitive="false" conf="logging->default"/> > + <dependency org="commons-logging" name="commons-logging" rev="1.1.3" > transitive="false" conf="logging->default"/> > <dependency org="org.eclipse.jetty.orbit" name="javax.servlet" > rev="3.0.0.v201112011016" transitive="false" conf="servlet->default"> > <artifact name="javax.servlet" type="orbit" ext="jar"/> > </dependency> > > > > On Wed, May 22, 2013 at 10:43 AM, Michael McCandless < > luc...@mikemccandless.com> wrote: > >> I think we should do this, so we can debug why HttpReplicatorTest >> keeps failing on OS X / Java 1.6: maybe something is happening and the >> logs will give a clue ... >> >> Mike McCandless >> >> http://blog.mikemccandless.com >> >> >> On Fri, May 17, 2013 at 8:45 AM, Robert Muir <rcm...@gmail.com> wrote: >> > put a log4j.properties as a resource or beside the test in svn. >> > >> > On Fri, May 17, 2013 at 7:18 AM, Shai Erera <ser...@gmail.com> wrote: >> >> Hi >> >> >> >> I noticed lucene/replicator tests output this warning: >> >> >> >> [junit4:junit4] 2> SLF4J: Failed to load class >> >> "org.slf4j.impl.StaticLoggerBinder". >> >> [junit4:junit4] 2> SLF4J: Defaulting to no-operation (NOP) logger >> >> implementation >> >> [junit4:junit4] 2> SLF4J: See >> >> http://www.slf4j.org/codes.html#StaticLoggerBinder for further >> details. >> >> >> >> In the webpage mentioned in the warning it's said that's because the >> >> classpath doesn't have one of slf4j bindings, e.g. slf4j-jdk. >> Replicator >> >> itself doesn't use logger at all, but InfoStream, so this must be >> something >> >> that comes from the Jetty libs. >> >> >> >> Is it a new thing? Do Solr tests output same warnings? Should we care >> about >> >> it? >> >> >> >> What's weird is that this is printed only when I run w/ >> >> -Dtestscase=HttpReplicatorTest, but not if I run 'ant test'. Maybe >> that's >> >> related to the debug info test-framework outputs if a single test is >> run vs >> >> all? >> >> >> >> Shai >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> > For additional commands, e-mail: dev-h...@lucene.apache.org >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> >
