[ 
https://issues.apache.org/jira/browse/SOLR-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670106#comment-13670106
 ] 

Uwe Schindler edited comment on SOLR-4877 at 5/30/13 6:44 AM:
--------------------------------------------------------------

Patch removing the special case for TermQuery.

The reson why this was here may be from older times: In Lucene 2.x, the collect 
method calculated the score of the Query, too. But since 3.x this is no longer 
the case, so there is no speed improvement by short-circuiting TermQuery. The 
original TermScorer/Collector code is identical.
                
      was (Author: thetaphi):
    Patch removing the special case for TermQuery.

The reson why this washere may be from older times: In Lucene 2.x, the collect 
method calculated the score of the Query, too. But since 3.x this is no longer 
the case, so there is no speec improvement by short-circuiting TermQuery. The 
original TermScorer/Collector code is identical.
                  
> SolrIndexSearcher#getDocSetNC should check for null return in 
> AtomicReader#fields()
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-4877
>                 URL: https://issues.apache.org/jira/browse/SOLR-4877
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.2, 4.3
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>         Attachments: SOLR-4877-nospecialcase.patch, SOLR-4877.patch
>
>
> In LUCENE-5023 it was reported that composite reader contexts should not 
> contain null fields() readers. But this is wrong, as a null-fields() reader 
> may contain documents,m just no fields.
> fields() is documented to contain null fields, so DocSets should check for 
> null (like all fields do in Lucene). It seems that DocSetNC does not 
> correctly check for null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to