[
https://issues.apache.org/jira/browse/SOLR-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671536#comment-13671536
]
Shawn Heisey commented on SOLR-4715:
------------------------------------
[~erickerickson], that was my thought too. I don't like option 2, even if it
spits out a WARN log, but it's one way of handling things, so I mentioned it.
I think we would struggle to find a valid use case for changing parser/writer
midstream. The only good time to set these things is at or right after object
creation.
Due to how the existing ctors work on the LB object, it seems like a good
option to add one more ctor with both parser and writer, but like you, I want
to avoid ctor explosion. Perhaps I could deprecate the one with just the
parser and remove it in trunk. I'd need to make sure that all ctors will work
with null values so users can override one but not the other, and log something
at INFO (or maybe DEBUG) saying that the default was chosen for null input.
My instinct after this discussion is to throw an exception at the LB level if
you attempt to change parser/writer after ServerWrapper objects have been
created. This means that the signature for the setter methods will include an
exception, but SolrServer doesn't have these methods, so there are no
inheritance problems with this. The javadocs will need to be very good.
> CloudSolrServer does not provide support for setting underlying server
> properties
> ---------------------------------------------------------------------------------
>
> Key: SOLR-4715
> URL: https://issues.apache.org/jira/browse/SOLR-4715
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.3
> Reporter: Hardik Upadhyay
> Assignee: Shawn Heisey
> Labels: solr, solrj
>
> CloudSolrServer (and LBHttpSolrServer) do not allow the user to set
> underlying HttpSolrServer and HttpClient settings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
